From 1ae484f775f0648f473dbf4fb18579da8ece870e Mon Sep 17 00:00:00 2001
From: Maria Margaritis <maria.margaritis@envite.de>
Date: Tue, 5 Mar 2024 23:08:09 +0100
Subject: [PATCH] Closes #2521 - Fix code smells
 Stream.collect(Collectors.toList()) to Stream.toList()

---
 .../pro/taskana/task/internal/jobs/TaskCleanupJob.java    | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/lib/taskana-core/src/main/java/pro/taskana/task/internal/jobs/TaskCleanupJob.java b/lib/taskana-core/src/main/java/pro/taskana/task/internal/jobs/TaskCleanupJob.java
index a49def538..67498ed4d 100644
--- a/lib/taskana-core/src/main/java/pro/taskana/task/internal/jobs/TaskCleanupJob.java
+++ b/lib/taskana-core/src/main/java/pro/taskana/task/internal/jobs/TaskCleanupJob.java
@@ -8,7 +8,6 @@ import java.time.Instant;
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
-import java.util.stream.Collectors;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 import pro.taskana.TaskanaConfiguration;
@@ -108,7 +107,7 @@ public class TaskCleanupJob extends AbstractTaskanaJob {
               .filter(not(entry -> entry.getKey().isEmpty()))
               .filter(not(entry -> entry.getValue().equals(countParentTask.get(entry.getKey()))))
               .map(Map.Entry::getKey)
-              .collect(Collectors.toList());
+              .toList();
 
       tasksToDelete =
           tasksToDelete.stream()
@@ -116,7 +115,7 @@ public class TaskCleanupJob extends AbstractTaskanaJob {
                   taskSummary ->
                       !taskIdsNotAllCompletedSameParentBusiness.contains(
                           taskSummary.getParentBusinessProcessId()))
-              .collect(Collectors.toList());
+              .toList();
     }
 
     return tasksToDelete;
@@ -138,8 +137,7 @@ public class TaskCleanupJob extends AbstractTaskanaJob {
   private int deleteTasks(List<TaskSummary> tasksToBeDeleted)
       throws InvalidArgumentException, NotAuthorizedException {
 
-    List<String> tasksIdsToBeDeleted =
-        tasksToBeDeleted.stream().map(TaskSummary::getId).collect(Collectors.toList());
+    List<String> tasksIdsToBeDeleted = tasksToBeDeleted.stream().map(TaskSummary::getId).toList();
     BulkOperationResults<String, TaskanaException> results =
         taskanaEngineImpl.getTaskService().deleteTasks(tasksIdsToBeDeleted);
     if (LOGGER.isDebugEnabled()) {