nosu
/
taskana
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Closes #2521 - Fix code smells Stream.collect(Collectors.toList()) to Stream.toList()

This commit is contained in:
Maria Margaritis 2024-03-05 23:28:09 +01:00
parent d3725c0d62
commit 30acd0a192
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
lib/taskana-core/src/main/java/pro/taskana/task/internal/ObjectReferenceHandler.java
View File

@ -56,9 +56,7 @@ public class ObjectReferenceHandler {
void insertAndDeleteObjectReferencesOnTaskUpdate(TaskImpl newTaskImpl, TaskImpl oldTaskImpl) void insertAndDeleteObjectReferencesOnTaskUpdate(TaskImpl newTaskImpl, TaskImpl oldTaskImpl)
throws ObjectReferencePersistenceException, InvalidArgumentException { throws ObjectReferencePersistenceException, InvalidArgumentException {
List<ObjectReference> newObjectReferences = List<ObjectReference> newObjectReferences =
newTaskImpl.getSecondaryObjectReferences().stream() newTaskImpl.getSecondaryObjectReferences().stream().filter(Objects::nonNull).toList();
.filter(Objects::nonNull)
.collect(Collectors.toList());
newTaskImpl.setSecondaryObjectReferences(newObjectReferences); newTaskImpl.setSecondaryObjectReferences(newObjectReferences);
for (ObjectReference objectReference : newObjectReferences) { for (ObjectReference objectReference : newObjectReferences) {
@ -81,7 +79,7 @@ public class ObjectReferenceHandler {
List<ObjectReference> newObjectReferences = List<ObjectReference> newObjectReferences =
newTaskImpl.getSecondaryObjectReferences().stream() newTaskImpl.getSecondaryObjectReferences().stream()
.filter(not(o -> oldObjectReferencesIds.contains(o.getId()))) .filter(not(o -> oldObjectReferencesIds.contains(o.getId())))
.collect(Collectors.toList()); .toList();
for (ObjectReference objectReference : newObjectReferences) { for (ObjectReference objectReference : newObjectReferences) {
insertNewObjectReferenceOnTaskUpdate(newTaskImpl, objectReference); insertNewObjectReferenceOnTaskUpdate(newTaskImpl, objectReference);
@ -115,8 +113,7 @@ public class ObjectReferenceHandler {
final List<ObjectReference> newObjectReferences = newTaskImpl.getSecondaryObjectReferences(); final List<ObjectReference> newObjectReferences = newTaskImpl.getSecondaryObjectReferences();
List<String> newObjectReferencesIds = new ArrayList<>(); List<String> newObjectReferencesIds = new ArrayList<>();
if (newObjectReferences != null && !newObjectReferences.isEmpty()) { if (newObjectReferences != null && !newObjectReferences.isEmpty()) {
newObjectReferencesIds = newObjectReferencesIds = newObjectReferences.stream().map(ObjectReference::getId).toList();
newObjectReferences.stream().map(ObjectReference::getId).collect(Collectors.toList());
} }
List<ObjectReference> oldObjectReferences = oldTaskImpl.getSecondaryObjectReferences(); List<ObjectReference> oldObjectReferences = oldTaskImpl.getSecondaryObjectReferences();
if (oldObjectReferences != null && !oldObjectReferences.isEmpty()) { if (oldObjectReferences != null && !oldObjectReferences.isEmpty()) {