From 493e25b56598b23a620769fb465543b5f3c6e614 Mon Sep 17 00:00:00 2001 From: Mustapha Zorgati <15628173+mustaphazorgati@users.noreply.github.com> Date: Mon, 18 May 2020 01:23:42 +0200 Subject: [PATCH] TSK-1214: refactored taskana-classification TSK-1214 Trying to make drag'n drop in tree possible TSK-1214 Removed refreshClassification output from tree TSK-1214 New action in store updates a classification and refetches all, saving now correctly refreshes the classification-list TSK-1214 Fixed tests in tree component TSK-1214 Removed tree service and corresponding test in class-details TSK-1214 fixed issues in tree where multiple actions to store are fired incorrectly TSK-1214 added accessibility action, use space to select a tree node TSK-1214 swapped space and enter in tree component, cleaned code TSK-1214 fixed bug where page isn't updated dynamically according to browser path TSK-1214 workaround circular dependency. service uses snapshot of store, does not actually access the state in store TSK-1214 fixed eslint. TODO: circular dependency between classification.service and classification.state TSK-1214 changed first() to take(1) to fix Observable dying during test TSK-1214 fixed test cases and lint issues TSK-1214 fixed circular dependency TSK-1214 devmode = false TSK-1214: fixed merge problems with notificationService and removed some warnings TSK-1214: fixed merge problems with notificationService TSK-1214 remove wrong imports from before merge --- .../src/main/resources/application.properties | 2 +- .../administration-routing.module.ts | 10 +- .../administration/administration.module.ts | 4 +- .../classification-details.component.html | 48 ++-- .../classification-details.component.scss | 3 + .../classification-details.component.spec.ts | 38 +-- .../classification-details.component.ts | 233 ++++++------------ .../classification-list.component.html | 38 +-- .../classification-list.component.spec.ts | 5 +- .../classification-list.component.ts | 161 ++++++------ .../classification-overview.component.html | 17 ++ .../classification-overview.component.scss | 0 .../classification-overview.component.spec.ts | 52 ++++ .../classification-overview.component.ts | 57 +++++ .../workbasket-access-items.component.ts | 2 +- .../workbasket-details.component.ts | 2 +- ...rkbasket-distribution-targets.component.ts | 2 +- .../workbasket-information.component.ts | 2 +- web/src/app/app.module.ts | 3 - .../components/spinner/spinner.component.ts | 5 +- .../components/tree/tree.component.html | 2 +- .../components/tree/tree.component.spec.ts | 83 ++++--- .../shared/components/tree/tree.component.ts | 118 +++++---- web/src/app/shared/models/action.ts | 4 +- .../models/classification-definition.ts | 6 +- .../shared/models/classification-resource.ts | 2 +- web/src/app/shared/models/classification.ts | 6 +- web/src/app/shared/models/notifications.ts | 4 +- web/src/app/shared/models/tree-node.ts | 6 +- .../shared/models/workbasket-definition.ts | 6 +- .../classifications.service.ts | 55 ++--- .../app/shared/services/tree/tree.service.ts | 15 -- .../classification.actions.ts | 54 +++- .../classification.selectors.ts | 22 ++ .../classification.state.ts | 155 +++++++++++- .../components/task/task.component.ts | 4 +- web/tsconfig.json | 2 +- 37 files changed, 727 insertions(+), 501 deletions(-) create mode 100644 web/src/app/administration/components/classification-overview/classification-overview.component.html create mode 100644 web/src/app/administration/components/classification-overview/classification-overview.component.scss create mode 100644 web/src/app/administration/components/classification-overview/classification-overview.component.spec.ts create mode 100644 web/src/app/administration/components/classification-overview/classification-overview.component.ts delete mode 100644 web/src/app/shared/services/tree/tree.service.ts diff --git a/rest/taskana-rest-spring-example-boot/src/main/resources/application.properties b/rest/taskana-rest-spring-example-boot/src/main/resources/application.properties index a8b493b1a..b0722d19c 100644 --- a/rest/taskana-rest-spring-example-boot/src/main/resources/application.properties +++ b/rest/taskana-rest-spring-example-boot/src/main/resources/application.properties @@ -23,7 +23,7 @@ taskana.schemaName=TASKANA ########spring.jpa.generate-ddl=true ########spring.jpa.properties.hibernate.jdbc.lob.non_contextual_creation=true ####### property that control rest api security deploy use true for no security. -devMode=false +devMode=true ####### property that control if the database is cleaned and sample data is generated generateSampleData=true diff --git a/web/src/app/administration/administration-routing.module.ts b/web/src/app/administration/administration-routing.module.ts index 8637829b2..f895f7c16 100644 --- a/web/src/app/administration/administration-routing.module.ts +++ b/web/src/app/administration/administration-routing.module.ts @@ -8,6 +8,7 @@ import { ClassificationListComponent } from 'app/administration/components/class import { ClassificationDetailsComponent } from 'app/administration/components/classification-details/classification-details.component'; import { DomainGuard } from 'app/shared/guards/domain.guard'; import { AccessItemsManagementComponent } from './components/access-items-management/access-items-management.component'; +import { ClassificationOverviewComponent } from './components/classification-overview/classification-overview.component'; const routes: Routes = [ { @@ -38,17 +39,17 @@ const routes: Routes = [ }, { path: 'classifications', - component: MasterAndDetailComponent, + component: ClassificationOverviewComponent, canActivate: [DomainGuard], children: [ { path: '', - component: ClassificationListComponent, + component: ClassificationOverviewComponent, outlet: 'master' }, { path: ':id', - component: ClassificationDetailsComponent, + component: ClassificationOverviewComponent, outlet: 'detail' }, { @@ -83,4 +84,5 @@ const routes: Routes = [ imports: [RouterModule.forChild(routes)], exports: [RouterModule] }) -export class AdministrationRoutingModule {} +export class AdministrationRoutingModule { +} diff --git a/web/src/app/administration/administration.module.ts b/web/src/app/administration/administration.module.ts index 13c9bc7a3..0cde5f73c 100644 --- a/web/src/app/administration/administration.module.ts +++ b/web/src/app/administration/administration.module.ts @@ -32,6 +32,7 @@ import { SavingWorkbasketService } from './services/saving-workbaskets.service'; import { ClassificationDefinitionService } from './services/classification-definition.service'; import { WorkbasketDefinitionService } from './services/workbasket-definition.service'; import { ImportExportService } from './services/import-export.service'; +import { ClassificationOverviewComponent } from './components/classification-overview/classification-overview.component'; const MODULES = [ CommonModule, @@ -53,10 +54,11 @@ const DECLARATIONS = [ WorkbasketInformationComponent, WorkbasketDistributionTargetsComponent, WorkbasketDualListComponent, + ClassificationOverviewComponent, ClassificationListComponent, - ImportExportComponent, ClassificationTypesSelectorComponent, ClassificationDetailsComponent, + ImportExportComponent, AccessItemsManagementComponent ]; diff --git a/web/src/app/administration/components/classification-details/classification-details.component.html b/web/src/app/administration/components/classification-details/classification-details.component.html index 815de9d69..df3e6ba99 100644 --- a/web/src/app/administration/components/classification-details/classification-details.component.html +++ b/web/src/app/administration/components/classification-details/classification-details.component.html @@ -1,48 +1,43 @@