nosu
/
taskana
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

TSK-1827: refactor some test names in QueryTasksWithSortingAccTest

This commit is contained in:
ryzheboka 2022-03-21 16:33:22 +01:00 committed by Elena Mokeeva
parent 4444816589
commit 5c70c1a7bb
1 changed files with 15 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
lib/taskana-core/src/test/java/acceptance/task/QueryTasksWithSortingAccTest.java
View File

@ -51,7 +51,7 @@ class QueryTasksWithSortingAccTest extends AbstractAccTest {
@WithAccessId(user = "admin") @WithAccessId(user = "admin")
@Test @Test
void should_sortByTaskIdDesc_When_TaskQueryFilterIsApplied() { void should_sortByTaskIdDesc() {
TaskService taskService = taskanaEngine.getTaskService(); TaskService taskService = taskanaEngine.getTaskService();
List<TaskSummary> results = List<TaskSummary> results =
taskService.createTaskQuery().orderByTaskId(SortDirection.DESCENDING).list(); taskService.createTaskQuery().orderByTaskId(SortDirection.DESCENDING).list();
@ -72,7 +72,7 @@ class QueryTasksWithSortingAccTest extends AbstractAccTest {
@WithAccessId(user = "admin") @WithAccessId(user = "admin")
@Test @Test
void should_sortByTaskIdAsc_When_TaskQueryFilterIsApplied() { void should_sortByTaskIdAsc_When_SortingDirectionIsNull() {
TaskService taskService = taskanaEngine.getTaskService(); TaskService taskService = taskanaEngine.getTaskService();
List<TaskSummary> results = taskService.createTaskQuery().orderByTaskId(null).list(); List<TaskSummary> results = taskService.createTaskQuery().orderByTaskId(null).list();
@ -93,7 +93,7 @@ class QueryTasksWithSortingAccTest extends AbstractAccTest {
class WorkbasketName { class WorkbasketName {
@WithAccessId(user = "admin") @WithAccessId(user = "admin")
@Test @Test
void should_sortByWorkbasketNameAsc_When_TaskQueryFilterIsApplied() { void should_sortByWorkbasketNameAsc() {
TaskService taskService = taskanaEngine.getTaskService(); TaskService taskService = taskanaEngine.getTaskService();
List<TaskSummary> results = List<TaskSummary> results =
taskService.createTaskQuery().orderByWorkbasketName(SortDirection.ASCENDING).list(); taskService.createTaskQuery().orderByWorkbasketName(SortDirection.ASCENDING).list();
@ -107,7 +107,7 @@ class QueryTasksWithSortingAccTest extends AbstractAccTest {
@WithAccessId(user = "admin") @WithAccessId(user = "admin")
@Test @Test
void should_sortByWorkbasketNameDsc_When_TaskQueryFilterIsApplied() { void should_sortByWorkbasketNameDsc() {
TaskService taskService = taskanaEngine.getTaskService(); TaskService taskService = taskanaEngine.getTaskService();
List<TaskSummary> results = List<TaskSummary> results =
taskService.createTaskQuery().orderByWorkbasketName(SortDirection.DESCENDING).list(); taskService.createTaskQuery().orderByWorkbasketName(SortDirection.DESCENDING).list();
@ -125,7 +125,7 @@ class QueryTasksWithSortingAccTest extends AbstractAccTest {
class Received { class Received {
@WithAccessId(user = "admin") @WithAccessId(user = "admin")
@Test @Test
void should_SortByReceivedAsc_When_TaskQueryFilterIsApplied() { void should_SortByReceivedAsc_When_FilterIsApplied() {
TaskService taskService = taskanaEngine.getTaskService(); TaskService taskService = taskanaEngine.getTaskService();
// we filter between EPOCH and null,to avoid null as a received value // we filter between EPOCH and null,to avoid null as a received value
List<TaskSummary> results = List<TaskSummary> results =
@ -146,7 +146,7 @@ class QueryTasksWithSortingAccTest extends AbstractAccTest {
class DomainNameAndCreated { class DomainNameAndCreated {
@WithAccessId(user = "admin") @WithAccessId(user = "admin")
@Test @Test
void testSortByDomainNameAndCreated() { void should_SortByDomainNameAndCreated() {
TaskService taskService = taskanaEngine.getTaskService(); TaskService taskService = taskanaEngine.getTaskService();
List<TaskSummary> results = List<TaskSummary> results =
taskService taskService
@ -170,7 +170,7 @@ class QueryTasksWithSortingAccTest extends AbstractAccTest {
class PorSystemNoteDueAndOwner { class PorSystemNoteDueAndOwner {
@WithAccessId(user = "admin") @WithAccessId(user = "admin")
@Test @Test
void testSortByPorSystemNoteDueAndOwner() { void should_SortByPorSystemNoteDueAndOwner_When_FilterIsApplied() {
TaskService taskService = taskanaEngine.getTaskService(); TaskService taskService = taskanaEngine.getTaskService();
List<TaskSummary> results = List<TaskSummary> results =
taskService taskService
@ -205,7 +205,7 @@ class QueryTasksWithSortingAccTest extends AbstractAccTest {
@WithAccessId(user = "admin") @WithAccessId(user = "admin")
@Test @Test
void testSortByPorSystemInstanceParentProcPlannedAndState() { void should_SortByPorSystemInstanceParentProcPlannedAndState_When_FilterIsApplied() {
TaskService taskService = taskanaEngine.getTaskService(); TaskService taskService = taskanaEngine.getTaskService();
List<TaskSummary> results = List<TaskSummary> results =
taskService taskService
@ -240,7 +240,7 @@ class QueryTasksWithSortingAccTest extends AbstractAccTest {
class PorCompanyClaimed { class PorCompanyClaimed {
@WithAccessId(user = "admin") @WithAccessId(user = "admin")
@Test @Test
void testSortByPorCompanyAndClaimed() { void should_SortByPorCompanyAndClaimed_When_FilterIsApplied() {
TaskService taskService = taskanaEngine.getTaskService(); TaskService taskService = taskanaEngine.getTaskService();
List<TaskSummary> results = List<TaskSummary> results =
taskService taskService
@ -275,13 +275,12 @@ class QueryTasksWithSortingAccTest extends AbstractAccTest {
class WbKeyPriorityPorValueAndCompleted { class WbKeyPriorityPorValueAndCompleted {
@WithAccessId(user = "admin") @WithAccessId(user = "admin")
@Test @Test
void testSortByWbKeyPrioPorValueAndCompleted() { void should_SortByPrioPorValueAndCompleted_When_FilterIsApplied() {
TaskService taskService = taskanaEngine.getTaskService(); TaskService taskService = taskanaEngine.getTaskService();
List<TaskSummary> results = List<TaskSummary> results =
taskService taskService
.createTaskQuery() .createTaskQuery()
.stateIn(TaskState.READY) .stateIn(TaskState.READY)
.orderByWorkbasketKey(null)
.workbasketIdIn("WBI:100000000000000000000000000000000015") .workbasketIdIn("WBI:100000000000000000000000000000000015")
.orderByPriority(SortDirection.DESCENDING) .orderByPriority(SortDirection.DESCENDING)
.orderByPrimaryObjectReferenceValue(SortDirection.ASCENDING) .orderByPrimaryObjectReferenceValue(SortDirection.ASCENDING)
@ -310,7 +309,7 @@ class QueryTasksWithSortingAccTest extends AbstractAccTest {
class BpiClassificationKeyAndPorType { class BpiClassificationKeyAndPorType {
@WithAccessId(user = "admin") @WithAccessId(user = "admin")
@Test @Test
void testSortBpIdClassificationIdDescriptionAndPorType() { void should_SortBpIdClassificationKeyAndPorType_When_FilterIsApplied() {
TaskService taskService = taskanaEngine.getTaskService(); TaskService taskService = taskanaEngine.getTaskService();
List<TaskSummary> results = List<TaskSummary> results =
taskService taskService
@ -344,7 +343,7 @@ class QueryTasksWithSortingAccTest extends AbstractAccTest {
@WithAccessId(user = "admin") @WithAccessId(user = "admin")
@Test @Test
void testSortByModifiedAndDomain() { void should_SortByModifiedAndDomain_When_FilterIsApplied() {
TaskService taskService = taskanaEngine.getTaskService(); TaskService taskService = taskanaEngine.getTaskService();
List<TaskSummary> results = List<TaskSummary> results =
taskService taskService
@ -386,7 +385,7 @@ class QueryTasksWithSortingAccTest extends AbstractAccTest {
class OwnerLongName { class OwnerLongName {
@WithAccessId(user = "admin") @WithAccessId(user = "admin")
@Test @Test
void should_ReturnOrderedResult_When_OrderByOwnerLongNameDescIsSet() { void should_OrderByOwnerLongNameDesc() {
List<TaskSummary> results = List<TaskSummary> results =
taskanaEngine taskanaEngine
.getTaskService() .getTaskService()
@ -401,7 +400,7 @@ class QueryTasksWithSortingAccTest extends AbstractAccTest {
@WithAccessId(user = "admin") @WithAccessId(user = "admin")
@Test @Test
void should_ReturnOrderedResult_When_OrderByOwnerLongNameAscIsSet() { void should_OrderByOwnerLongNameAsc() {
List<TaskSummary> results = List<TaskSummary> results =
taskanaEngine.getTaskService().createTaskQuery().orderByOwnerLongName(ASCENDING).list(); taskanaEngine.getTaskService().createTaskQuery().orderByOwnerLongName(ASCENDING).list();
assertThat(results.stream().filter(r -> r.getOwnerLongName() != null)) assertThat(results.stream().filter(r -> r.getOwnerLongName() != null))
@ -434,7 +433,7 @@ class QueryTasksWithSortingAccTest extends AbstractAccTest {
@Disabled @Disabled
@WithAccessId(user = "admin") @WithAccessId(user = "admin")
@Test @Test
void testQueryTaskValuesForClassificationName() { void should_OrderByClassificationNameAndListClassificationNameColumn() {
TaskService taskService = taskanaEngine.getTaskService(); TaskService taskService = taskanaEngine.getTaskService();
List<String> columnValueList = List<String> columnValueList =
taskService taskService