From 9a188f015f8aef6d07c043a0411d400c7785555c Mon Sep 17 00:00:00 2001 From: Mustapha Zorgati <15628173+mustaphazorgati@users.noreply.github.com> Date: Mon, 17 Oct 2022 05:36:40 +0200 Subject: [PATCH] TSK-1919: fixed query offeset tests by comparing entire object --- .../query/QueryClassificationHistoryAccTest.java | 10 +++------- .../java/acceptance/query/QueryTaskHistoryAccTest.java | 6 +++--- .../taskcomment/query/QueryTaskCommentAccTest.java | 5 +++-- 3 files changed, 9 insertions(+), 12 deletions(-) diff --git a/history/taskana-simplehistory-provider/src/test/java/acceptance/query/QueryClassificationHistoryAccTest.java b/history/taskana-simplehistory-provider/src/test/java/acceptance/query/QueryClassificationHistoryAccTest.java index cf61f01ac..ffd9357bb 100644 --- a/history/taskana-simplehistory-provider/src/test/java/acceptance/query/QueryClassificationHistoryAccTest.java +++ b/history/taskana-simplehistory-provider/src/test/java/acceptance/query/QueryClassificationHistoryAccTest.java @@ -24,10 +24,6 @@ class QueryClassificationHistoryAccTest extends AbstractAccTest { private final SimpleHistoryServiceImpl historyService = getHistoryService(); - public QueryClassificationHistoryAccTest() { - super(); - } - @Test void should_ConfirmEquality_When_UsingListValuesAscendingAndDescending() { List defaultList = @@ -80,9 +76,9 @@ class QueryClassificationHistoryAccTest extends AbstractAccTest { historyService.createClassificationHistoryQuery().list(); assertThat(offsetAndLimitResult).hasSize(2); - assertThat(offsetAndLimitResult.get(0).getUserId()) - .isNotEqualTo(regularResult.get(0).getUserId()) - .isEqualTo(regularResult.get(1).getUserId()); + assertThat(offsetAndLimitResult.get(0)) + .isNotEqualTo(regularResult.get(0)) + .isEqualTo(regularResult.get(1)); } @Test diff --git a/history/taskana-simplehistory-provider/src/test/java/acceptance/query/QueryTaskHistoryAccTest.java b/history/taskana-simplehistory-provider/src/test/java/acceptance/query/QueryTaskHistoryAccTest.java index c60515122..d0f5dd480 100644 --- a/history/taskana-simplehistory-provider/src/test/java/acceptance/query/QueryTaskHistoryAccTest.java +++ b/history/taskana-simplehistory-provider/src/test/java/acceptance/query/QueryTaskHistoryAccTest.java @@ -76,9 +76,9 @@ class QueryTaskHistoryAccTest extends AbstractAccTest { List regularResult = getHistoryService().createTaskHistoryQuery().list(); assertThat(offsetAndLimitResult).hasSize(2); - assertThat(offsetAndLimitResult.get(0).getUserId()) - .isNotEqualTo(regularResult.get(0).getUserId()) - .isEqualTo(regularResult.get(1).getUserId()); + assertThat(offsetAndLimitResult.get(0)) + .isNotEqualTo(regularResult.get(0)) + .isEqualTo(regularResult.get(1)); } @Test diff --git a/lib/taskana-core/src/test/java/acceptance/taskcomment/query/QueryTaskCommentAccTest.java b/lib/taskana-core/src/test/java/acceptance/taskcomment/query/QueryTaskCommentAccTest.java index b05808e7d..a477b99d8 100644 --- a/lib/taskana-core/src/test/java/acceptance/taskcomment/query/QueryTaskCommentAccTest.java +++ b/lib/taskana-core/src/test/java/acceptance/taskcomment/query/QueryTaskCommentAccTest.java @@ -238,8 +238,9 @@ class QueryTaskCommentAccTest extends AbstractAccTest { List regularResult = taskService.createTaskCommentQuery().list(); assertThat(offsetAndLimitResult).hasSize(2); - assertThat(offsetAndLimitResult.get(0).getId()).isNotEqualTo(regularResult.get(0).getId()); - assertThat(offsetAndLimitResult.get(0).getId()).isEqualTo(regularResult.get(1).getId()); + assertThat(offsetAndLimitResult.get(0)) + .isNotEqualTo(regularResult.get(0)) + .isEqualTo(regularResult.get(1)); } @WithAccessId(user = "admin")