nosu
/
taskana
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

TSK-734: Made allowedKeys a static class member

This commit is contained in:
julian.schallenmueller 2018-11-15 08:04:58 +01:00 committed by Mustapha Zorgati
parent 51af51196e
commit b480f0532f
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lib/taskana-core/src/main/java/pro/taskana/impl/TaskServiceImpl.java
View File

@ -65,6 +65,8 @@ public class TaskServiceImpl implements TaskService {
private static final String ID_PREFIX_BUSINESS_PROCESS = "BPI"; private static final String ID_PREFIX_BUSINESS_PROCESS = "BPI";
private static final String MUST_NOT_BE_EMPTY = " must not be empty"; private static final String MUST_NOT_BE_EMPTY = " must not be empty";
private static final Duration MAX_DURATION = Duration.ofSeconds(Long.MAX_VALUE, 999_999_999); private static final Duration MAX_DURATION = Duration.ofSeconds(Long.MAX_VALUE, 999_999_999);
private static final Set<String> ALLOWED_KEYS = new HashSet<>(
Arrays.asList("1", "2", "3", "4", "5", "6", "7", "8", "9", "10", "11", "12", "13", "14", "15", "16"));
private DaysToWorkingDaysConverter converter; private DaysToWorkingDaysConverter converter;
private TaskanaEngineImpl taskanaEngine; private TaskanaEngineImpl taskanaEngine;
private WorkbasketService workbasketService; private WorkbasketService workbasketService;
@ -1156,12 +1158,9 @@ public class TaskServiceImpl implements TaskService {
throw new InvalidArgumentException("The customFieldsToUpdate argument to updateTasks must not be empty."); throw new InvalidArgumentException("The customFieldsToUpdate argument to updateTasks must not be empty.");
} }
Set<String> allowedKeys = new HashSet<>(
Arrays.asList("1", "2", "3", "4", "5", "6", "7", "8", "9", "10", "11", "12", "13", "14", "15", "16"));
for (Map.Entry<String, String> entry : customFieldsToUpdate.entrySet()) { for (Map.Entry<String, String> entry : customFieldsToUpdate.entrySet()) {
String key = entry.getKey(); String key = entry.getKey();
if (!allowedKeys.contains(key)) { if (!ALLOWED_KEYS.contains(key)) {
throw new InvalidArgumentException( throw new InvalidArgumentException(
"The customFieldsToUpdate argument to updateTasks contains invalid key " + key); "The customFieldsToUpdate argument to updateTasks contains invalid key " + key);
} }