diff --git a/lib/taskana-core/src/main/java/pro/taskana/task/internal/TaskCommentServiceImpl.java b/lib/taskana-core/src/main/java/pro/taskana/task/internal/TaskCommentServiceImpl.java index 9303dc3db..a46fc456a 100644 --- a/lib/taskana-core/src/main/java/pro/taskana/task/internal/TaskCommentServiceImpl.java +++ b/lib/taskana-core/src/main/java/pro/taskana/task/internal/TaskCommentServiceImpl.java @@ -67,8 +67,6 @@ class TaskCommentServiceImpl { taskanaEngine.openConnection(); - taskService.getTask(taskCommentImplToUpdate.getTaskId()); - TaskComment originalTaskComment = getTaskComment(taskCommentImplToUpdate.getId()); if (originalTaskComment.getCreator().equals(userId) diff --git a/rest/taskana-rest-spring/src/test/java/pro/taskana/rest/TaskCommentControllerIntTest.java b/rest/taskana-rest-spring/src/test/java/pro/taskana/rest/TaskCommentControllerIntTest.java index 163bce46a..9463b3033 100644 --- a/rest/taskana-rest-spring/src/test/java/pro/taskana/rest/TaskCommentControllerIntTest.java +++ b/rest/taskana-rest-spring/src/test/java/pro/taskana/rest/TaskCommentControllerIntTest.java @@ -214,34 +214,7 @@ class TaskCommentControllerIntTest { .extracting(ex -> ((HttpClientErrorException) ex).getStatusCode()) .isEqualTo(HttpStatus.FORBIDDEN); } - - @Test - void should_FailToUpdateTaskComment_When_TaskIsNotExisting() { - final ObjectMapper mapper = new ObjectMapper(); - - TaskCommentResource taskCommentResourceToUpdate = new TaskCommentResource(); - taskCommentResourceToUpdate.setTaskId("TKI:000000000000000000000000000000009999"); - taskCommentResourceToUpdate.setTaskCommentId("TCI:000000000000000000000000000000000000"); - taskCommentResourceToUpdate.setTextField("updated text"); - - String url = - restHelper.toUrl(Mapping.URL_TASK_COMMENT, "TCI:000000000000000000000000000000000000"); - - ThrowingCallable httpCall = - () -> { - template.exchange( - url, - HttpMethod.PUT, - new HttpEntity<>( - mapper.writeValueAsString(taskCommentResourceToUpdate), - restHelper.getHeadersUser_1_1()), - ParameterizedTypeReference.forType(TaskCommentResource.class)); - }; - assertThatThrownBy(httpCall) - .extracting(ex -> ((HttpClientErrorException) ex).getStatusCode()) - .isEqualTo(HttpStatus.NOT_FOUND); - } - + @Test void should_FailToUpdateTaskComment_When_TaskCommentIdInResourceDoesNotMatchPathVariable() {