nosu
/
taskana
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

TSK-402: fix for isRead flag update.

This commit is contained in:
Holger Hagen 2018-04-16 12:10:22 +02:00 committed by Martin Rojas Miguel Angel
parent 149ac8d296
commit fea40d79bc
2 changed files with 28 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/taskana-core/src/main/java/pro/taskana/impl/TaskServiceImpl.java
View File

@ -585,7 +585,7 @@ public class TaskServiceImpl implements TaskService {
try { try {
taskanaEngine.openConnection(); taskanaEngine.openConnection();
task = (TaskImpl) getTask(taskId); task = (TaskImpl) getTask(taskId);
task.setRead(true); task.setRead(isRead);
task.setModified(Instant.now()); task.setModified(Instant.now());
taskMapper.update(task); taskMapper.update(task);
LOGGER.debug("Method setTaskRead() set read property of Task '{}' to {} ", task, isRead); LOGGER.debug("Method setTaskRead() set read property of Task '{}' to {} ", task, isRead);

27
lib/taskana-core/src/test/java/acceptance/task/UpdateTaskAccTest.java
View File

@ -3,10 +3,12 @@ package acceptance.task;
import static org.hamcrest.core.IsEqual.equalTo; import static org.hamcrest.core.IsEqual.equalTo;
import static org.hamcrest.core.IsNot.not; import static org.hamcrest.core.IsNot.not;
import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertNotEquals; import static org.junit.Assert.assertNotEquals;
import static org.junit.Assert.assertNotNull; import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertNull; import static org.junit.Assert.assertNull;
import static org.junit.Assert.assertThat; import static org.junit.Assert.assertThat;
import static org.junit.Assert.assertTrue;
import static org.junit.Assert.fail; import static org.junit.Assert.fail;
import java.sql.SQLException; import java.sql.SQLException;
@ -183,6 +185,31 @@ public class UpdateTaskAccTest extends AbstractAccTest {
assertEquals(task.getDescription(), updatedTask.getDescription()); assertEquals(task.getDescription(), updatedTask.getDescription());
} }
@WithAccessId(
userName = "user_1_2",
groupNames = {"group_1"})
@Test
public void testUpdateReadFlagOfTask()
throws TaskNotFoundException, WorkbasketNotFoundException, ClassificationNotFoundException,
InvalidArgumentException, ConcurrencyException, InvalidWorkbasketException, NotAuthorizedException,
AttachmentPersistenceException {
TaskService taskService = taskanaEngine.getTaskService();
taskService.setTaskRead("TKI:000000000000000000000000000000000030", true);
Task updatedTask = taskService.getTask("TKI:000000000000000000000000000000000030");
assertNotNull(updatedTask);
assertTrue(updatedTask.isRead());
assertFalse(updatedTask.getCreated().equals(updatedTask.getModified()));
taskService.setTaskRead("TKI:000000000000000000000000000000000030", false);
Task updatedTask2 = taskService.getTask("TKI:000000000000000000000000000000000030");
assertNotNull(updatedTask2);
assertFalse(updatedTask2.isRead());
assertFalse(updatedTask2.getModified().equals(updatedTask.getModified()));
}
@WithAccessId( @WithAccessId(
userName = "user_1_1", userName = "user_1_1",
groupNames = {"group_1"}) groupNames = {"group_1"})